search

jwhitley / requirejs-rails

RequireJS support for your Rails 3 or 4 application
MIT License
592 stars 202 forks source link

Fixes `config.assets.manifest` issue #259

Closed Deradon closed 8 years ago

Deradon commented 8 years ago

Problem

Setting the Rails config config.assets.manifest using a recent sprockets version (>= 3.0) makes the use of Requirejs::Rails impossible.

Sprockets change the content of the configuration from being a directory to a file. Requirejs::Rails was still expecting a directory.

Solution

Get the dirname of the given value if this value is a path to a file.

carsomyr commented 8 years ago

@Deradon Would a simpler solution be to normalize everything using Pathname objects?

Deradon commented 8 years ago

Hey @carsomyr, I opened this PR here by accident. Wanted to create a PR within my fork first.

This PR is kind of a hotfix solution to try something. I'll investigate this issue a bit further.

We noticed that within our rails app the asset deployment takes a lot of time. The main reason for this is the requirejs-rails gem.

So I'll have a look at the lib/task directory, too.

Please ignore my proposed solution here, it's just a quick'n dirty test ;)

Feel free to close this PR!

Deradon commented 8 years ago

As I already mentioned this PR is a duplicate of: https://github.com/jwhitley/requirejs-rails/pull/249 So I'll close it.