search

jwhitley / requirejs-rails

RequireJS support for your Rails 3 or 4 application
MIT License
592 stars 202 forks source link

Fix: check environment Gzip option #260

Open Strech opened 8 years ago

Strech commented 8 years ago

In the sprockets you can disable gzipping your assets, but requirejs-rails ignore this option. The second commit change Sprockets env call to the defined variable, instead of new ::Rails.application.assets call.

Strech commented 8 years ago

Ah, I found that gzip? appears only in sprockets 3.x, will add check about gzip? method

Strech commented 8 years ago

@carsomyr Hi, can you have a look on this PR?

Deradon commented 8 years ago

:+1: :trollface:

scudelletti commented 8 years ago

Anyone? Ping @carsomyr, @billmag, @jwhitley

billmag commented 8 years ago

Hey @scudelletti -- apologies, but I'm no longer actively working on the project that uses this and have been out of touch on recent changes. @jwhitley or @carsomyr will have to reply.

scudelletti commented 8 years ago

Thanks for the reply @billmag we will wait for them.

jwhitley commented 8 years ago

Sorry, I'm not much immediate help either. @carsomyr has been the active maintainer of this project for years now; I'm very out of touch. However, I'm happy to help get some additional maintainer assistance in place if life's pulled Roy in other directions.