jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
828 stars 68 forks source link

Add forge to async-bytecomp-allowed-packages #114

Closed tarsius closed 4 years ago

tarsius commented 4 years ago

Without this I constantly have to tell users "Uninstall ghub and forge. Restart Emacs. Install forge again." Just today I had to do that three times and in every case that fixed the issue.

thierryvolpiatto commented 4 years ago

May be we could make 'all the default? See also for this kind of issues the order of package installation. Don't know about ghub and forge, but if one is the dependency of the other and you make a change in the dependency and you use this changed code in the other, you have to install (upgrade) the dependency before the other. See https://github.com/melpa/melpa/issues/6336 The Helm interface for package.el takes care of this.

tarsius commented 4 years ago

but if one is the dependency of the other and you make a change in the dependency and you use this changed code in the other, you have to install (upgrade) the dependency before the other.

Yeah... if users report impossible errors, then I usually recommend the trinity kludge: uninstall, restart, and reinstall.

The Helm interface for package.el takes care of this.

That seems like a really strange place to do it. Did you try to get that merged?

May be we could make 'all the default?

I think package.el itself should learn to use another Emacs instance to update and generally be improved to avoid issues like these.