jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
828 stars 68 forks source link

fix inclusion of bytecomp variables #138

Closed Stebalien closed 3 years ago

Stebalien commented 3 years ago

The regexp was inclusing all variables ending with byte, not variables starting with byte-.

thierryvolpiatto commented 3 years ago

Basil L. Contovounesios notifications@github.com writes:

@basil-conto commented on this pull request.

━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

In async-bytecomp.el:

@@ -91,7 +91,7 @@ All *.elc files are systematically deleted before proceeding." (async-start `(lambda () (require 'bytecomp)

  • ,(async-inject-variables "\`\(load-path\)\|byte\'")
  • ,(async-inject-variables "\`\(load-path\'\|byte-\)")

By shy I mean \(?:...\) instead of \(...\), as I don't see the captured match group being used anywhere, though I could be wrong.

You are right the match group is not used, you can use the shy group safely.

-- Thierry

thierryvolpiatto commented 3 years ago

Thanks merged!