search

jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
838 stars 68 forks source link

Last commit is breaking (as expected) most existing code. #20

Closed thierryvolpiatto closed 10 years ago

thierryvolpiatto commented 10 years ago

The last pull request is breaking most existing code, starting by helm-async.el, many of the tests given by john in several places, and probably dired-async.el too. I guess external libraries that are using async.el maybe broken too. @jwiegley Please revert it.

thierryvolpiatto commented 10 years ago

So you should revert to 242ae734273162f4ec027618610a099c9a73557b

Thanks.

thierryvolpiatto commented 10 years ago

Sorry forget it, I didn't notice the last commit, it is now working.

thierryvolpiatto commented 10 years ago

So yes, these changes are breaking code, actually, smtpmail-async is broken, and I suspect more code to be broken. I have created a stable branch that revert these changes...

jwiegley commented 10 years ago

Can we revert to that stable branch on master then?

thierryvolpiatto commented 10 years ago

John Wiegley notifications@github.com writes:

Can we revert to that stable branch on master then?

Yes that would be better, and instead make a lex branch that we will merge later when fully fixed.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

jwiegley commented 10 years ago

@thierryvolpiatto So which commit do I need to revert on master again, just so that I get it right?

thierryvolpiatto commented 10 years ago

John Wiegley notifications@github.com writes:

@thierryvolpiatto So which commit do I need to revert on master again, just so that I get it right?

242ae734273162f4ec027618610a099c9a73557b

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

jwiegley commented 10 years ago

Done.

thierryvolpiatto commented 10 years ago

We misunderstand, you have to revert all commits down to 242ae734273162f4ec027618610a099c9a73557b not included.

thierryvolpiatto commented 10 years ago

So the HEAD of master should be the same as "stable" branch.

jwiegley commented 10 years ago

Should be done now. master amtches 242ae73 (origin/stable).

thierryvolpiatto commented 10 years ago

Thanks John, that's correct now, I will delete now the stable branch. So we have now master which is stable and the lex branch that contains the last changes made by Ryan Thompson.