jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
838 stars 68 forks source link

dired copy and move don't work anymore #35

Closed dinojr closed 10 years ago

dinojr commented 10 years ago

I'm running Emacs 24.4.50.1 from the package emacs-snapshot in Ubuntu 14.04 and async-20140912.517 from elpa. Copy and Move don't work anymore in dired: in the Messages buffer, I get

Copy: 0 files Copy proceeding asynchronously...

The modeline display [1 Async job(s) running](the 1 changes later to 0) but nothing is copied or moved.

I ran emacs -Q followed by (require 'package) (package-initialize) (when (require 'dired-aux) (require 'dired-async))

thierryvolpiatto commented 10 years ago

The last change is breaking async, i have fixed this but will not be able to commit my fix until next week. Sorry for the inconvenience. Le 17 sept. 2014 12:19, "Julien Cubizolles" notifications@github.com a écrit :

I'm running Emacs 24.4.50.1 from the package emacs-snapshot in Ubuntu 14.04 and async-20140912.517 from elpa. Copy and Move don't work anymore in dired: in the Messages buffer, I get

Copy: 0 files Copy proceeding asynchronously...

The modeline display 1 Async job(s) running http://the%201%20changes%20later%20to%200 but nothing is copied or moved.

I ran emacs -Q followed by (require 'package) (package-initialize) (when (require 'dired-aux) (require 'dired-async))

— Reply to this email directly or view it on GitHub https://github.com/jwiegley/emacs-async/issues/35.

dinojr commented 10 years ago

On 17 septembre 2014 17:39:58 CEST, Thierry Volpiatto notifications@github.com wrote:

The last change is breaking async, i have fixed this but will not be able to commit my fix until next week. Sorry for the inconvenience. Le 17 sept. 2014 12:19, "Julien Cubizolles" notifications@github.com a écrit :

I'm running Emacs 24.4.50.1 from the package emacs-snapshot in Ubuntu 14.04 and async-20140912.517 from elpa. Copy and Move don't work anymore in dired: in the Messages buffer, I get

Copy: 0 files Copy proceeding asynchronously...

The modeline display 1 Async job(s) running http://the%201%20changes%20later%20to%200 but nothing is copied or moved.

I ran emacs -Q followed by (require 'package) (package-initialize) (when (require 'dired-aux) (require 'dired-async))

— Reply to this email directly or view it on GitHub https://github.com/jwiegley/emacs-async/issues/35.


Reply to this email directly or view it on GitHub: https://github.com/jwiegley/emacs-async/issues/35#issuecomment-55913168

Ok, I'll check next week.

Envoyé d'un smartphone. veuillez excuser la brièveté.

snosov1 commented 10 years ago

Hi!

I also have a similar bug, when I'm trying to copy a file, but nothing happens. Only a message [0 Async job(s) running] pops up in the mode line and it never goes away.

I like this package very much, and, please, don't take it to your heart, but the experience with dired-async was not very pleasant for me "regression-wise". Like, it is not the first time, when the most basic functionality (copying in dired) breaks and stays broken for a while, leaving me no way around, but to disable the whole async thing.

A friendly suggestion to you, guys, would be that maybe should you reconsider the way you develop this package. Like, merge to master only once in a while and after a thorough testing. Because this package is really fundamental - you simply cannot work when it breaks.

thierryvolpiatto commented 10 years ago

Sergei Nosov notifications@github.com writes:

Hi!

I also have a similar bug, when I'm trying to copy a file, but nothing happens. Only a message [0 Async job(s) running] pops up in the mode line and it never goes away.

I like this package very much, and, please, don't take it to your heart, but the experience with dired-async was not very pleasant for me "regression-wise". Like, it is not the first time, when the most basic functionality (copying in dired) breaks and stays broken for a while, leaving me no way around, but to disable the whole async thing.

It stay broken two or three days at least because I was travelling, note that all these packages are developped by people that do this job freely on their sparse time...

In a similar situation you can always revert your package to previous working commit.

A friendly suggestion to you, guys, would be that maybe should you reconsider the way you develop this package. Like, merge to master only once in a while and after a thorough testing. Because this package is really fundamental - you simply cannot work when it breaks.

Please update your package and recompile it, it is working fine actually.

If you want to use only stable packages, use melpa-stable package-archives, if you install from git use a tagged version actually v1.2.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

snosov1 commented 10 years ago

Please update your package and recompile it, it is working fine actually.

Well, it is not for me. My workstation is Ubuntu 12.04 (x64), Emacs 24.3.1. With my configurations it works as I described - shows a message, which never goes away and does nothing else. If I run Emacs with -Q flag and then require dired-aux and dired-async, it gives me the error "Wrong type argument: stringp, nil" when I try to copy a file.

It stay broken two or three days at least because I was travelling, note that all these packages are developped by people that do this job freely on their sparse time...

Please, don't take it as an insult. I understand this very well and really appreciate the effort. My point is that given the project alters a very fundamental functionality and you have a limited amount of time to work on it, maybe it makes sense to push things to master only once in a while when you're certain, that it passes the smoke tests, at least.

If you want to use only stable packages, use melpa-stable package-archives, if you install from git use a tagged version actually v1.2.

This suggestion is legit, if you treat Melpa as a source for unstable packages. However, my understanding and experience is that not many developers treat it as one. And most of the users actually use Melpa by default and expect the packages to be fairly stable. Something might be broken in a nasty corner case once in a while, but you should still have all the important things working.

I wouldn't have brought this up if it was the first time when something like copying doesn't work. What can you do, shit happens. But it was actually the second time for me when the very core functionality in this package breaks.

snosov1 commented 10 years ago

Sorry for confusion, it works for me with the latest version - async-20140929.456. It didn't work with the async-20140924.432. So, thanks!

But in any case, I think, my other points are legit. =)