jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
838 stars 68 forks source link

package--compile with async selects compile log buffer #36

Closed michael-heerdegen closed 10 years ago

michael-heerdegen commented 10 years ago

This is different from the vanilla behavior and annoying. When you upgrade packages with the adviced package--compile, you are queried in the minibuffer if the old versions should be removed (normal), but unlike vanilla Emacs, the compile log buffer is selected then, you have to switch back manually to the minibuffer.

michael-heerdegen commented 10 years ago

Another difference to vanilla Emacs is that we generate a new compile log buffer for every compiled package. After upgrading multiple packages, you see only the compile log of the last compiled package. This is not so useful. Is this intended to allow support multiple compilations in parallel?

thierryvolpiatto commented 10 years ago

Michael Heerdegen notifications@github.com writes:

Another difference to vanilla Emacs is that we generate a new compile log buffer for every compiled package.

Should be fixed now.

Thanks.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

thierryvolpiatto commented 10 years ago

Michael Heerdegen notifications@github.com writes:

This is different from the vanilla behavior and annoying. When you upgrade packages with the adviced package--compile, you are queried in the minibuffer if the old versions should be removed (normal), but unlike vanilla Emacs, the compile log buffer is selected then, you have to switch back manually to the minibuffer.

Unless you use special-display* for compile buffer, now the compile buffer should not be selected anymore.

BTW, you can use `helm-list-elisp-packages' to upgrade, use M-I to show installed packages, you will see duplicates, mark the old versions and delete, then M-x helm-resume and mark the uninstalled packages in list and install them.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

michael-heerdegen commented 10 years ago

Thierry Volpiatto notifications@github.com writes:

Unless you use special-display* for compile buffer, now the compile buffer should not be selected anymore.

Thanks so far. I'll test it as soon as some packages are to be upgraded.

BTW, you can use `helm-list-elisp-packages' to upgrade, use M-I to show installed packages, you will see duplicates, mark the old versions and delete, then M-x helm-resume and mark the uninstalled packages in list and install them.

That doesn't seem very intuitive. It would be better if I could directly upgrade.

thierryvolpiatto commented 10 years ago

Michael Heerdegen notifications@github.com writes:

Thierry Volpiatto notifications@github.com writes:

Unless you use special-display* for compile buffer, now the compile buffer should not be selected anymore.

Thanks so far. I'll test it as soon as some packages are to be upgraded.

BTW, you can use `helm-list-elisp-packages' to upgrade, use M-I to show installed packages, you will see duplicates, mark the old versions and delete, then M-x helm-resume and mark the uninstalled packages in list and install them.

That doesn't seem very intuitive. It would be better if I could directly upgrade.

Upgrade is not implemented yet, PR welcome ;-)

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

michael-heerdegen commented 10 years ago

Seems this works now. But another thing is irritating now. After compilation has finshed, the echo area shows the last compilation message:

Directory `/home/micha/...' compiled asynchronously with success

This hides the minibuffer prompting for whether to delete the old package versions. Only manual intervention makes the minibuffer visisble.

thierryvolpiatto commented 10 years ago

Michael Heerdegen notifications@github.com writes:

Seems this works now. But another thing is irritating now. After compilation has finshed, the echo area shows the last compilation message:

Directory `/home/micha/...' compiled asynchronously with success

This hides the minibuffer prompting for whether to delete the old package versions. Only manual intervention makes the minibuffer visisble.

Should be fixed now.

Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997

michael-heerdegen commented 10 years ago

I think it works well now, thanks.