search

jwiegley / emacs-async

Simple library for asynchronous processing in Emacs
GNU General Public License v3.0
832 stars 68 forks source link

Please review makefile #77

Closed thierryvolpiatto closed 7 years ago

thierryvolpiatto commented 7 years ago

@jwiegley I added a makefile.

The motivation is to install async in a standard location where other packages can find it when compiling. Until now I guess nobody use really async.el itself due to this problem. For example I wanted to use async-let in helm, ok no problem but as soon I ran make to compile helm, I ended up with errors complaining async where not found because it was installed in mu elisp directory which is not a standard location. See https://github.com/emacs-helm/helm/wiki#from-source.

Can you please review the makefile and correct if necessary ?

Thanks.

jwiegley commented 7 years ago

It looks good to me, @thierryvolpiatto. But I guess the real answer is: let's get this into Emacs. All we need is to confirm copyright assignments for all contributions, and then we can commit it into 'master' core, towards Emacs 26.

thierryvolpiatto commented 7 years ago

John Wiegley notifications@github.com writes:

It looks good to me, @thierryvolpiatto. But I guess the real answer is: let's get this into Emacs. All we need is to confirm copyright assignments for all contributions, and then we can commit it into 'master' core, towards Emacs 26.

Ah! yes, of course that would be great!

-- Thierry Gpg Key fingerprint = 6CEC 7081 AB33 E251 4AB8 5FC2 28D1 7F53 59F2 9997

thierryvolpiatto commented 7 years ago

AFAICT when looking at https://github.com/jwiegley/emacs-async/graphs/contributors only @DarwinAwardWinner makes big changes but IIRC they have been reverted at the time because breaking async.el, the other changes are mostly README changes.

DarwinAwardWinner commented 7 years ago

In case any of my changes are still in, I've already signed the copyright assignment forms for Emacs.

thierryvolpiatto commented 7 years ago

Ryan C. Thompson notifications@github.com writes:

In case any of my changes are still in, I've already signed the copyright assignment forms for Emacs.

Great! thanks.

-- Thierry Gpg Key fingerprint = 6CEC 7081 AB33 E251 4AB8 5FC2 28D1 7F53 59F2 9997

jwiegley commented 7 years ago

Then if we're good for assignment, do you think we're ready to push into master? I'll probably open up a discussion for comments first.

thierryvolpiatto commented 7 years ago

John Wiegley notifications@github.com writes:

Then if we're good for assignment, do you think we're ready to push into master?

Yes, will be a nice addition to emacs, I have released version 1.9.2, the package seems stable.

I'll probably open up a discussion for comments first.

Ok, thanks.

-- Thierry Gpg Key fingerprint = 6CEC 7081 AB33 E251 4AB8 5FC2 28D1 7F53 59F2 9997

thierryvolpiatto commented 7 years ago

@jwiegley when you open a discussion please Cc me as I generally don't follow emacs lists. Thanks for reviewing makefile, closing now.