search

jwiegley / gitlib

180 stars 56 forks source link

Migrate to unliftio, away from monad-control #76

Closed mstksg closed 6 years ago

mstksg commented 6 years ago

Hi! Thanks for the great libraries.

Due to changes in the conduit/resourcet ecosystem, a lot of things now no longer work with monad-control/MonadBaseControl functions (some instances have appeared to disappear from those libraries), so I've tried my best to see if it makes sense to move the entire library to unliftio/MonadUnliftIO style. Things seem to have been pretty straightforward!

Let me know if this isn't the direction you want to go, or if there's anything I can touch up!

jwiegley commented 6 years ago

Wow, great work. I'd actually done this locally too, but forgot to push, so I'm sorry to have wasted your time!

mstksg commented 6 years ago

No worries! And not a waste of time, it was a good excuse to me to finally get around to learning how to do this unliftio migration thing :)