search

jwiegley / gitlib

180 stars 56 forks source link

Fix flag issue with GCC 7. #79

Closed TravisWhitaker closed 2 years ago

TravisWhitaker commented 6 years ago

Without the -Wno-format-security flag, GCC 7 fails with this error:

cc1: error: -Wformat-security ignored without -Wformat [-Werror=format-security]
ghost commented 6 years ago

Building HEAD with gcc 8.2.1 works for me. Did gcc 7 report the error in the bindings or libgit2? If it's in libgit2, it's probably better to fix it upstream and update the libgit2 revision. That is, unless gcc's format-security warnings were false positives.