jwiegley / use-package

A use-package declaration for simplifying your .emacs
https://jwiegley.github.io/use-package
GNU General Public License v3.0
4.4k stars 260 forks source link

regression: adds `-mode` to hooks #1000

Closed ensc closed 1 year ago

ensc commented 2 years ago

With

(use-package some-lib
  :defer 1
  :hook ((other-mode . 'some-lib/conf-fn)))

(message "hook: %s" other-mode-hook)

I got with use-package-20210207.1926

"hook: (some-lib)"

But now with use-package-20220910.25, it is

"hook: (some-lib-mode)"

This breaks existing configurations when some-lib does not define -mode function.

doolio commented 1 year ago

Why are you using a quote here? Does the following not work for you?

(use-package some-lib
  :defer 1
  :hook (other-mode . conf-fn))
ensc commented 1 year ago

without quoting it works; thx