search

jwiegley / use-package

A use-package declaration for simplifying your .emacs
https://jwiegley.github.io/use-package
GNU General Public License v3.0
4.42k stars 260 forks source link

typo, should be a vector, not a bytecode object #843

Closed nahuel closed 4 years ago

nahuel commented 4 years ago

Solves https://github.com/jwiegley/use-package/issues/842

arichiardi commented 4 years ago

It looks good to me, thanks for the quick fix - kind of scared this morning when I woke up that I broke something yesterday :smile:

jwiegley commented 4 years ago

Thank you!

Silex commented 4 years ago

So this was broken since two (!) years :scream:

https://github.com/jwiegley/use-package/blame/0ba3071cda77957822bfe3e58009375f395777f4/use-package-core.el#L1033

Original commit: https://github.com/jwiegley/use-package/commit/c60387a31b25f71e78e968b6e6a98bd4fe092f82#diff-8ef140df8b4408418fab781244480094R1027

Kinda scary :-)

stsquad commented 4 years ago

I just ran into this again when updating one of my other machines to native-comp which follow melpa-stable rather than melpa. It's been some time since there was a tagged release - is it time to cut a new one so fixes (including this one) can be available for people who follow stable?

jwiegley commented 4 years ago

Yes, good idea, it's time to tag a release.

MorganJamesSmith commented 4 years ago

I recently ran into this issue using the Gnu Guix package manager which uses tag 2.4. I would really appreciate a new release :)