search

jwiegley / use-package

A use-package declaration for simplifying your .emacs
https://jwiegley.github.io/use-package
GNU General Public License v3.0
4.39k stars 259 forks source link

README.md: Should we change `ess-site` into `ess-r-mode`? #928

Closed snowman closed 3 years ago

snowman commented 3 years ago

Question

Should we change ess-site into ess-r-mode like below:

(use-package ess-site
  :disabled
  :commands R)

into

(use-package ess-r-mode
  :disabled
  :commands R)

Details

ess-site package: https://github.com/jwiegley/use-package/blob/a7422fb8ab1baee19adb2717b5b47b9c3812a84c/README.md#L453-L457

https://github.com/jwiegley/use-package/blob/a7422fb8ab1baee19adb2717b5b47b9c3812a84c/README.md#L613-L617

https://github.com/jwiegley/use-package/blob/a7422fb8ab1baee19adb2717b5b47b9c3812a84c/README.md#L626-L634

ESS package: https://github.com/emacs-ess/ESS/blob/b501beec408b66e2f2a8c4f3117e0c84ee1b0262/lisp/ess-r-mode.el#L615-L619

;;;###autoload
(defun R (&optional start-args)
  (interactive "P")
  ;; FIXME: Current ob-R expects current buffer set to process buffer
  (set-buffer (run-ess-r start-args)))

https://github.com/emacs-ess/ESS/blob/b501beec408b66e2f2a8c4f3117e0c84ee1b0262/lisp/ess-r-mode.el#L2879

(provide 'ess-r-mode)
snowman commented 3 years ago

Okay, my bad, In ess-site package:

https://github.com/emacs-ess/ESS/blob/b501beec408b66e2f2a8c4f3117e0c84ee1b0262/lisp/ess-site.el#L56

(require 'ess-r-mode)