search

jwiegley / use-package

A use-package declaration for simplifying your .emacs
https://jwiegley.github.io/use-package
GNU General Public License v3.0
4.39k stars 259 forks source link

Avoid positional arguments to define-minor-mode #936

Closed tarsius closed 2 years ago

tarsius commented 3 years ago

Back in Emacs-21.1, define-minor-mode grew keyword arguments to replace its old positional arguments. Starting with Emacs-28.1 a warning will be omitted if positional arguments are still used.

tarsius commented 3 years ago

Friendly ping. (This is quite a trivial change.)

johnhamelink commented 2 years ago

I tried this PR and it removed the following warnings from my warnings buffer:

5 matches for "positional" in buffer: *Warnings*
     17:Warning (comp): bind-key.el:132:20: Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode' Disable showing Disable logging
     33:Warning (comp): pcre2el.el:719:3: Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode' Disable showing Disable logging
     35:Warning (comp): pcre2el.el:1249:20: Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode' Disable showing Disable logging
     76:Warning (comp): tablist.el:304:22: Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode' Disable showing Disable logging
     77:Warning (comp): tablist.el:997:5: Warning: Use keywords rather than deprecated positional arguments to `define-minor-mode' Disable showing Disable logging

Please consider merging this!

tarsius commented 2 years ago

Another friendly ping!

jwiegley commented 2 years ago

Sorry @tarsius, wasn't paying enough attention to the queue of pull requests.