README installation instructions produce 'invalid get repo specification' error

[mpjashby]

The installation instructions in the package README:

library(devtools)
install_github("RMETAR", "jwijffels", subdir="/pkg")

produce the error:

Error in parse_repo_spec(repo) : Invalid git repo specification: 'RMETAR'

The same error occurs with the equivalent function from the remotes package that replaced devtools, i.e. when using remotes::install_github() in place of devtools::install_github().

Might it be useful to change the code in these instructions to something similar to the following?

install.packages("remotes")
remotes::install_github("jwijffels/RMETAR")

[jwijffels]

Sure! That needs to be updated.

[vvxin]

same error, but failed to use install_github("jwijffels/RMETAR")

`Downloading GitHub repo jwijffels/RMETAR@master ✓ checking for file ‘/private/var/folders/mn/9vkph_cs2db1dp72wx_t80r40000gn/T/Rtmpm01CqK/remotes7886bb17001/jwijffels-RMETAR-ba2bd1b/DESCRIPTION’ (780ms) ─ preparing ‘RMETAR’: ✓ checking DESCRIPTION meta-information ... ─ cleaning src ─ checking for LF line-endings in source and make files and shell scripts ─ checking for empty or unneeded directories ─ building ‘RMETAR_1.0.tar.gz’

• installing source package ‘RMETAR’ ... using staged installation libs clang -mmacosx-version-min=10.13 -I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I/usr/local/include -fPIC -Wall -g -O2 -c METAR_R_extraction.c -o METAR_R_extraction.o In file included from METAR_R_extraction.c:5: In file included from ./metar_structs.h:39: ./local.h:1036:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(ASCTOEB, OS)

  ^

  ./local.h:1039:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(EAXLATE, OS)

  ^

  ./local.h:1042:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(PASCTOEB, OS)

  ^

  ./local.h:1049:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(CCAPREAD, OS)

  ^

  ./local.h:1052:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(CCAPWRIT, OS)

  ^

  ./local.h:1055:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(PPTOI, OS)

  ^

  ./local.h:1119:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(readrec, OS)

  ^

  ./local.h:1122:9: warning: unknown pragma ignored [-Wunknown-pragmas]

  pragma linkage(writerec, OS)

  ^

  ./local.h:1190:7: error: conflicting types for 'strnstr' char strnstr(char , char , size_t); ^ /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include/string.h:161:7: note: previous declaration is here char strnstr(const char __big, const char __little, size_t __len); ^ METAR_R_extraction.c:31:40: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare] if(Mptr->RRVR[element].vrbl_visRange != MAXINT) vrbl_visRange = ScalarInteger(Mptr->RRVR[element].vrbl_visRange); else vrbl_visRange = ScalarInteger(NA_INTEGER);

  
  METAR_R_extraction.c:32:40: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
  if(Mptr->RRVR[element].below_min_RVR != MAXINT) below_min_RVR = ScalarInteger(Mptr->RRVR[element].below_min_RVR); else below_min_RVR = ScalarInteger(NA_INTEGER);
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~
  METAR_R_extraction.c:33:40: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
  if(Mptr->RRVR[element].above_max_RVR != MAXINT) above_max_RVR = ScalarInteger(Mptr->RRVR[element].above_max_RVR); else above_max_RVR = ScalarInteger(NA_INTEGER);
   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~
  METAR_R_extraction.c:67:30: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
  if(Mptr->DVR.vrbl_visRange != MAXINT) vrbl_visRange = ScalarInteger(Mptr->DVR.vrbl_visRange); else vrbl_visRange = ScalarInteger(NA_INTEGER);
   ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~
  METAR_R_extraction.c:68:30: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
  if(Mptr->DVR.below_min_DVR != MAXINT) below_min_DVR = ScalarInteger(Mptr->DVR.below_min_DVR); else below_min_DVR = ScalarInteger(NA_INTEGER);
   ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~
  METAR_R_extraction.c:69:30: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
  if(Mptr->DVR.above_max_DVR != MAXINT) above_max_DVR = ScalarInteger(Mptr->DVR.above_max_DVR); else above_max_DVR = ScalarInteger(NA_INTEGER);
   ~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~
  METAR_R_extraction.c:134:28: warning: result of comparison of constant 2147483647 with expression of type 'MDSP_BOOL' (aka 'unsigned short') is always true [-Wtautological-constant-out-of-range-compare]
  if(Mptr->winData.windVRB != MAXINT) windVRB = ScalarInteger(Mptr->winData.windVRB); else windVRB = ScalarInteger(NA_INTEGER);
   ~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~
  15 warnings and 1 error generated.
  make: *** [METAR_R_extraction.o] Error 1
  ERROR: compilation failed for package ‘RMETAR’

• removing ‘/Library/Frameworks/R.framework/Versions/4.0/Resources/library/RMETAR’ 错误: Failed to install 'RMETAR' from GitHub: (由警告转换成)installation of package ‘/var/folders/mn/9vkph_cs2db1dp72wx_t80r40000gn/T//Rtmpm01CqK/file7884e3088e3/RMETAR_1.0.tar.gz’ had non-zero exit status`

[jwijffels]

@andrie Are you working still on this?

[andrie]

I haven't worked on this for a while, but IIRC the dev branch can be merged to master.

[jwijffels]

@vvxin Can you install from the dev branch https://github.com/jwijffels/RMETAR/tree/dev

[vvxin]

Do you mean remotes::install_github("jwijffels/RMETAR/tree/dev") ? doesn't work

Error: Failed to install 'unknown package' from GitHub:
  HTTP error 404.
  Not Found

  Did you spell the repo owner (`jwijffels`) and repo name (`RMETAR`) correctly?
  - If spelling is correct, check that you have the required permissions to access the repo.

But remotes::install_github("jwijffels/RMETAR") works on my other computer! Maybe R version problem? Now I'm at R 3.6 instead of 4.

Thanks anyway!

[andrie]

To install from a different branch, e.g. dev, try:

remotes::install_github("jwijffels/RMETAR@dev")