Error in handling single quotes

FrankRensen commented 1 year ago

I have this label defined in my AL code. SetupMssg: Label '%1 %2 %3 %4 %5 or '''' (empty) should be setup';

This is included in de translation file as: %1 %2 %3 %4 %5 or '' (empty) should be setup

After performing the action NAB: Update all XLF files, it shows in the nl-translation file as: %1 %2 %3 %4 %5 or ' (empty) should be setup

Source has been modified.

Versions used VSCode: 1.78.1 (User setup) AL Language extension for Microsoft Dynamics 365 Business Central: v11.0.787898 NAB AL Tools: v.1.20.0

To Reproduce See above

Expected behavior After performing the action NAB: Update all XLF files, it shows in the nl-translation file as: %1 %2 %3 %4 %5 or '' (empty) should be setup

Does it happen all the time? Yes
Did it used to work? Never seen this before,

jwikman commented 1 year ago

Hi @FrankRensen,

I agree, this should work (but haven't seen that one before obviously).

I'll try to find some time to dig into it.

jwikman commented 1 year ago

Hi @FrankRensen,

I think I found the cause to this issue.

Try out the pre-release version v1.31.305121921 and see if this is solved for you as well.

FrankRensen commented 1 year ago

It’s solved:

  <trans-unit id="Codeunit 147223021 - Method 185995981 - NamedType 247311055" size-unit="char" translate="yes" xml:space="preserve">
      <source>%1 %2 %3 %4 %5 or '' (empty) should be setup</source>
      <target>[NAB: REVIEW]%1 %2 %3 %4 %5 of '' (leeg) moet worden aangemaakt</target>
      <note from="Developer" annotates="general" priority="2"></note>

ThankS!

Met vriendelijke groeten,

Frank Rensen

Van: Johannes Wikman @.> Verzonden: vrijdag 12 mei 2023 21:31 Aan: jwikman/nab-al-tools @.> CC: Frank Rensen @.>; Mention @.> Onderwerp: Re: [jwikman/nab-al-tools] Error in handling single quotes (Issue #433)

Hi @FrankRensenhttps://github.com/FrankRensen,

I think I found the cause to this issue.

Try out the pre-release version v1.31.305121921 and see if this is solved for you as well.

— Reply to this email directly, view it on GitHubhttps://github.com/jwikman/nab-al-tools/issues/433#issuecomment-1546190312, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A7YLTHCG7RJPXU3WN5ZPJ2TXF2FYXANCNFSM6AAAAAAX55Y6QQ. You are receiving this because you were mentioned.Message ID: @.***>

jwikman commented 1 year ago

Great @FrankRensen, thanks for confirming!

jwikman / nab-al-tools

Error in handling single quotes #433