search

jwikman / nab-al-tools

The code repository for NAB AL Tools, an AL tool for VS Code
https://marketplace.visualstudio.com/items?itemName=nabsolutions.nab-al-tools
MIT License
19 stars 7 forks source link

Filtering in xlf editor doesn't work in Workspace #466

Open nikolajovicic opened 2 months ago

nikolajovicic commented 2 months ago

Describe the bug When we open more BC extensions together in wokrkspace, but our code-workspace file isn't in same root as extension folders, so we in Workspace have this structure:

"folders": [ { "name": "Extension 1", "path": "Extension 1/app" }, { "name": "Test Extension 1", "path": "Extension 1/test" }, { "name": "Extension 2", "path": "Extension 2/app" }, { "name": "Test Extension 2", "path": "Extension 2/test" } ]

When we go to XLF file for any of this extensions, call command NAB:EDIT Xliff Dokument

image

Clicking on filtering options does not apply. When we open project as folder or as workspace were app folders and code-workspace file are in same root, then works.

Versions used VSCode: 1.93.1 NAB AL Tools: 1.32.0

To Reproduce Steps to reproduce the behavior:

  1. Open workspace with multiple extensions where folders and workspace file are not in same root, such as described in Describe the bug section.
  2. Open one XLF file in some of this extensions
  3. Open Xliff editor
  4. try to apply some filters
  5. See error

Expected behavior Filter is working

Screenshots image

nikolalazovic1 commented 2 months ago

The same thing happens to me.

jwikman commented 2 months ago

Hi @nikolajovicic,

I cannot reproduce this behavior... Are you sure that there are no settings that are different in the two .code-workspace files? Are they identical, except from the structure of the workspace projects?

The two screenshots above are identical, from what I can see, is that intentional?

In step 5 you say that there is an error, can you provide the error message?

Thanks, Johannes