jwillmer / jekyllDecent

Blog Template for Jekyll
http://jwillmer.github.io/jekyllDecent/
MIT License
133 stars 123 forks source link

Use GH Issues as discussion system #38

Open alxsimo opened 7 years ago

alxsimo commented 7 years ago

Maybe can be a good idea to add support for using GH Issues as discussion system instead of Disqus: http://donw.io/post/github-comments/

Very useful for programming or IT blogs.

jwillmer commented 7 years ago

I know that blog post and have thought about it myself. This is what the post is saying about Disqus:

With the current Disqus implementation we don't have the above problems. We don't start loading comments (Disqus) before someone clicks on view comments. This way loading of the website is fast and people who like to read the comments/add a comment can still do it.

This is how a site load looks with Disqus support enabled (no unnecessary requests!) loading

That sad, the only reason I can see for replacing Disqus with GH issues (as comments) is because there is currently a hype about the GH comments system and it comes down to personal flavor.

I don't mind to support two comment systems as long as they are easy to setup and to replace. So if someone likes to have GH comments (you?) please feel free to implement it and send me a pull request.

I am closing this issue since I will currently not implement it.

alxsimo commented 7 years ago

Sure! I will do it

jwillmer commented 7 years ago

Sorry, I did not recognize that the pull request of the Disqus implementation was actually from you. I guess I did not needed to tell you how it works :speak_no_evil: