search

jwillmer / jekyllDecent

Blog Template for Jekyll
http://jwillmer.github.io/jekyllDecent/
MIT License
133 stars 124 forks source link

Add comment count to Disqus #40

Open jwillmer opened 7 years ago

jwillmer commented 7 years ago

I thought about changing the "Load comments" into "Load 5 Comments" to give an indication how much comments are there. The goal is to do this without loading the whole Disqus overhead. Turns out, someone did it already and inspecting his demo (use raymondcamden and open dev tools) I can see that Disqus does not load any bloatware.

Let's implement it? @alexsimo

alxsimo commented 7 years ago

Not bad idea! But would be the flow? an infinite scroll? or maybe the user will need to click the button every time wants 5 more comments?

jwillmer commented 7 years ago

No, sorry, my example is misleading. I only like to show that are a number N amount of comments already. So I know if there are comments I can read.

Load Comment Section (5💬)

alxsimo commented 7 years ago

Oh! Understood now! Yes! Looks good for me! I'll assign myself but not sure when can make it.

alxsimo commented 7 years ago

Seems I can't do it myself. Assign me please

jwillmer commented 7 years ago

Strange, I can't find you in the assignee drop-down. I wrote GitHub support to have a look. I will assign you as soon as I can :point_up:

jwillmer commented 7 years ago

From the support team:

This has to do with the fact that the user opened that original issue and it can therefore be assigned to him, versus in this case, you opened the issue and the user is not a collaborator and thus can't be assigned to the issue.

I can promote you to collaborator if you don't mind to still use pull requests and not commit directly.

alxsimo commented 7 years ago

Sure!

On Fri, Jun 2, 2017, 13:34 Jens Willmer notifications@github.com wrote:

From the support team:

This has to do with the fact that the user opened that original issue and it can therefore be assigned to him, versus in this case, you opened the issue and the user is not a collaborator and thus can't be assigned to the issue.

I will promote you to collaborator if you don't mind to still use pull requests and not commit directly.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jwillmer/jekyllDecent/issues/40#issuecomment-305762083, or mute the thread https://github.com/notifications/unsubscribe-auth/AAjXiXuAvKk1X2TNYXMTFG3tcd1J1oF5ks5r__NIgaJpZM4Nssin .

--

Alexandru Vladut Simonescu

Software Craftsman. Android Developer. Yoga Lover.

Blog http://blog.alexsimo.com/ | GitHub https://github.com/alexsimo | LinkedIn https://es.linkedin.com/in/alexandrusimonescu | Twitter http://twitter.com/alexsimonescu