Closed edgarrmondragon closed 1 year ago
@tayloramurphy do you have a (useful) recommended way forward here to get target-duckdb working w/Python 3.10? Does Meltano support 3.10 yet?
@jwills Meltano itself supports 3.10 (https://github.com/meltano/meltano/issues/2830) - a dependency of this target does not. Seems like getting https://github.com/transferwise/pipelinewise-singer-python/pull/92/files merged would be a way to go.
@jwills @tayloramurphy afaict the only thing being imported from the singer library is get_logger
, which can easily be ported to this package.
If we also make sure to explicitly bring any transitive dependencies of the library, we can remove it.
@edgarrmondragon amaze, let me try it out
Okay PR is up, PTAL @edgarrmondragon
This is fixed now :)
Is your feature request related to a problem? Please describe.
Installing in Python 3.9 works fine
``` $ pipx install target-duckdb --verbose --python=$(pyenv which python3.9) pipx >(setup:757): pipx version is 1.1.0 pipx >(setup:758): Default python interpreter is '/usr/local/Cellar/pipx/1.1.0/libexec/bin/python3.10' pipx >(package_name_from_spec:323): Determined package name: target-duckdb pipx >(package_name_from_spec:324): Package name determined in 0.0s creating virtual environment... pipx >(run_subprocess:173): running /Users/edgarramirez/.pyenv/versions/3.9.14/bin/python3.9 -m venv --without-pip /Users/edgarramirez/.local/pipx/venvs/target-duckdb pipx >(run_subprocess:173): running /Users/edgarramirez/.local/pipx/venvs/target-duckdb/bin/python -c import sysconfig; print(sysconfig.get_path('purelib')) pipx >(run_subprocess:173): running /Users/edgarramirez/.local/pipx/shared/bin/python -c import sysconfig; print(sysconfig.get_path('purelib')) pipx >(run_subprocess:173): running /Users/edgarramirez/.local/pipx/venvs/target-duckdb/bin/python --version pipx >(_parsed_package_to_package_or_url:128): cleaned package spec: target-duckdb installing target-duckdb... pipx >(run_subprocess:173): running /Users/edgarramirez/.local/pipx/venvs/target-duckdb/bin/python -m pip install target-duckdb pipx >(run_subprocess:173): runningbut fails on 3.10:
As you can see, the root issue seems to be
pipelinewise-singer-python
depending onorjson==3.6.1
, which didn't publish binary wheels for macOS+cp310.Describe the solution you'd like
Dropping the dependency on
pipelinewise-singer-python
might be the quickest way to fix this, otherwise we'd have to wait for them to release a new package with a newerorjson
pinned.Describe alternatives you've considered
Don't run this on macOS 😅