jwills / target-duckdb

A Singer.io target for DuckDB
Other
17 stars 12 forks source link

Use quotes for database and schema name #33

Closed JichaoS closed 7 months ago

JichaoS commented 7 months ago

Without quotes, duckdb complains about table creation for database/schema names starting with a number. Say an uuid.

Problem

For a database named "1.duckdb" the table creation logic fails with duckdb error Error: Parser Error: syntax error at or near "1"

Proposed changes

Add quotes around database and schema names to allow for numerical prefixed database/schemas

Types of changes

What types of changes does your code introduce to PipelineWise? Put an x in the boxes that apply

JichaoS commented 7 months ago

Pretty simple change. I can add test too if you'd like.

jwills commented 7 months ago

looks fine, just going to make sure tests pass

jwills commented 7 months ago

ugh, lots of motherduck failures cause of the stupid secrets issue; there must be a way to fix this but for the time being i will just run this locally

jwills commented 7 months ago

Everything ran perfectly locally-- thank you @JichaoS!