Fix issue #36 - Githubissues

jwills commented 4 months ago

Problem

We have a bug where the update operation fails on ingest when all of the columns are primary keys.

If all of the columns in a table are primary keys, skip the UPDATE operation-- there's nothing for us to do there.

What types of changes does your code introduce to PipelineWise? Put an x in the boxes that apply

[X] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)

[ ] Description above provides context of the change
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Unit tests for changes (not needed for documentation changes)
[ ] CI checks pass with my changes
[ ] Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
[ ] Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
[ ] Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
[ ] Commits follow "How to write a good git commit message"
[ ] Relevant documentation is updated including usage instructions

jwills commented 4 months ago

Fixes #36

jwills commented 4 months ago

This is failing for MD reasons; will run a test with it against 0.9.2 and ensure it works there