search

jwilm / racerd

Rust semantic analysis server powered by Racer
http://jwilm.github.io/racerd/libracerd/
Apache License 2.0
134 stars 24 forks source link

Update racer to master. #58

Closed emilio closed 8 years ago

emilio commented 8 years ago

Racer hasn't been published in a while. I was setting up YouCompleteMe, when I found that racerd panicked pretty frequently inside racer.

Updated racer solved the problem, but I needed to modify racerd a bit, so this is the minimal set of modifications that allowed me to build.

Obviously the git dependency path would need to be changed to a proper version when racer is published, I'm just leaving this here in case this is useful for someone.

jwilm commented 8 years ago

Thanks doing this! I'll get this merged either tonight or in the morning.

emilio commented 8 years ago

On Tue, Oct 18, 2016 at 08:58:32AM -0700, Joe Wilm wrote:

I'd like to remove the unsafe stuff currently used to leak FileCache. This involves trimming down the new function and removing drop.

Do you fancy making those changes, or may I add a commit to your feature?

Happy to do the changes when I arrive from class, should be straight-forward :)

Super appreciate you updating Racer by the way!

No problem! A few months ago I did try to set it up, it failed so I removed it. Yesterday I felt like actually making it work whatever the cost was :)

emilio commented 8 years ago

Done, let me know if this is sort of what you were looking for :)

jwilm commented 8 years ago

Yeah this is exactly what I had in mind :). Thanks for the extra work! Going to test that this runs on my machine and then will either leave a comment or merge.

jwilm commented 8 years ago

Everything looks good! Thanks for the commits 😄

emilio commented 8 years ago

No problem! :)