search

jwilsson / domtokenlist

A super duper strict shim/polyfill for DOMTokenList, classList and relList.
MIT License
12 stars 16 forks source link

Checking implementation #5

Closed TrySound closed 9 years ago

TrySound commented 9 years ago

How about checking implementation for fully shim?

var el = document.createElement('div');
el.classList.add('c1', 'c2');
if(el.className !== 'c1 c2') {
  // Bad implementation
}
jwilsson commented 9 years ago

Yeah, that's a good idea!

I'm just a bit unsure if all browsers will allow us to override their native implementation. Do you wanna send a PR and we'll test it out?

TrySound commented 9 years ago

Give me please access to repository for direct PR.

TrySound commented 9 years ago

Here nice idea.

We will check classList if native DOMTokeList exists and modify it, not redefining.

TrySound commented 9 years ago

Also I want to work with minifying. This shim is "most wanted" for me. So it should be as small as possible.

jwilsson commented 9 years ago

Send some PRs and we'll continue the discussion there

TrySound commented 9 years ago

I just would like to develop this as a collaborator without forking.

jwilsson commented 9 years ago

Alright, adding you!

TrySound commented 9 years ago

Cool! Thanks! Will contribute :)

jwilsson commented 9 years ago

For future reference: Closed in 99838ea1a4fe4f7a38c1a01394bb3ff65c0dc44f.