search

jwinarske / meta-flutter

Yocto meta layer for recipes related to using Google Flutter Engine
MIT License
45 stars 22 forks source link

Fetch flutter-engine using https and upgrade to gcc 9.3.0 #14

Closed v-morlock closed 3 years ago

v-morlock commented 3 years ago

Hello,

this pull request introduces two changes:

Pull Flutter Engine using https Currently, the source is loaded using git which seems to be impossible without a valid ssh key registered at github. As this broke our CI, I want to propose using https for fetching this dependency.

Link crtbeginS & crtendS from gcc 9.3.0 In my builds, i faced issues when linking those dependencies as in my environment, the used path was invalid and 9.3.0 was present. Thus I assume this is the current version on dunfell.

Feedback appreciated!

Thanks, Valentin

jwinarske commented 3 years ago

Hi @v-morlock!

Full disclosure, I was hired by a company (look at my Linked in) to do this full time, and have since created a superior implementation. Unfortunately there are numerous companies using this repository, and have not provided anything back, so this repository has languished. So thank you for being the first :1st_place_medal:

Yes I'm aware of the git vs https thing. Git was a dependency for downloading one or more dependencies, at one point in time. This may have since gone away. It needs thorough testing to ensure it's not breaking a corner case. The economy of scale there tells me it may not be worth it. What's the concern with having anonymous access?

v-morlock commented 3 years ago

Hi @jwinarske

thanks for your prompt reply - and sad to hear you did not receive any contributions on this project. I assume the superior version you created is an internal project of your new company?

Regarding my patch: the problem using git-https is our gitlab-pipeline which is (at the moment) not running with a ssh keys known to github - thus, we were unable running the build without this change. I tested it in my environment and it seemed to work quite fine, but of course that's probably not what one would consider thorough testing.

dvescovi1 commented 3 years ago

hi @jwinarske my build also broke but luckily stumbled across this PR. Fixing the the git@ vs https did indeed fix my build issue also. Thank you for the great work!

jwinarske commented 3 years ago

@v-morlock I also build with a gitlab pipeline. I have not seen this problem. I suspect it's a runner config issue.

jwinarske commented 3 years ago

@dvescovi1 thanks

flukejones commented 3 years ago

@jwinarske is the work you've done since going to be rolled in to this repo?

jwinarske commented 3 years ago

Closing since dunfell branch is current