search

jwise / naim

naim is a console client for AOL Instant Messenger (AIM), AOL I Seek You (ICQ), Internet Relay Chat (IRC), and The lily CMC.
http://naim.n.ml.org/
GNU General Public License v2.0
8 stars 5 forks source link

_nlua_pdvcall and _nlua_hook should be unified #4

Closed jwise closed 12 years ago

jwise commented 12 years ago

Those two functions vastly need to be refactored; _nlua_pdvcall is currently a half-ass implementation of _nlua_hook that, importantly, doesn't support writing back to HOOK_T_WR*. They both start with their own lookup of choice, but really should be refactored out into a single 'call hook that's already on the Lua stack' routine. This currently causes a bug in jwise/naim-oscar that has to be hacked around by having the PD add a preselect hook of its own.

jwise commented 12 years ago

Closed by 50c897c. Fucking finally.