search

jwjacobson / jazztunes

a jazz repertoire management app
https://jazztunes.org
GNU General Public License v3.0
3 stars 0 forks source link

Allow searching by timespan only #145

Closed jwjacobson closed 6 months ago

jwjacobson commented 6 months ago

As search is currently written, timespan is an exclude() added to the end of the search term filtering, which means it doesn't operate if there are no search terms. A very useful feature will be to instead return all tunes played within a certain timespan. I think an if search_terms is none with an early return should take care of it...

jwjacobson commented 6 months ago

This seems to have started working just by adding required=False to the search_term field on the SearchForm, but I'm leaving this open for now in case I'm wrong

bbelderbos commented 6 months ago

ok cool, I will try it out locally tomorrow ...