search

jwjacobson / jazztunes

a jazz repertoire management app
https://jazztunes.org
GNU General Public License v3.0
4 stars 1 forks source link

Edit tune button is not opening the write tunes to edit #78

Closed jwjacobson closed 10 months ago

jwjacobson commented 10 months ago

I assume this is a problem with the view which I will look at tomorrow. The edit button either opens the wrong tune or returns an error (probably because looking for a non-existent tune_id)

jwjacobson commented 10 months ago

Same thing is happening with delete

bbelderbos commented 10 months ago

Works or me adding 2 tunes, let's look in a bit then, how to reproduce this issue?

jwjacobson commented 10 months ago

I was tired when I wrote this issue, maybe it's not clear, it should say "right tunes" instead of "write tunes." Adding tunes is fine, it's just editing or deleting that works but on the wrong tune. I suspect maybe it is confusion between tune and repertoire_tune ids? I notice that the repertoire_tune table automatically has its own "id" field that maybe is getting swapped for tune_id

bbelderbos commented 10 months ago

Fixed here: https://github.com/jwjacobson/jazz_repertoire/pull/82