jwjacobson / jazztunes

a jazz repertoire management app
https://jazztunes.org
GNU General Public License v3.0
3 stars 1 forks source link

make columns sortable on results table #93

Closed bbelderbos closed 6 months ago

bbelderbos commented 8 months ago

Not sure if htmx can do it, otherwise we can write some vanilla JS, please let me know ...

bbelderbos commented 8 months ago

The only sortable on htmx' example page is a drag and drop: https://htmx.org/examples/

ryaustin commented 8 months ago

yeah might be nice to add js and keep it light weight. or if you want to geek out datatables: https://datatables.net/ very performant too. I use it on paginated tables with hundreds of rows.

bbelderbos commented 8 months ago

https://stackoverflow.com/questions/55462632/javascript-sort-table-column-on-click < ideas, but there might also be a plugin for it.

Here is some (ugly) code I could retrieve from our platform (notice the link) :)

function sortTable(n, divId) {
  /* https://www.w3schools.com/howto/howto_js_sort_table.asp */
  var table, rows, switching, i, x, y, shouldSwitch, dir, switchcount = 0;
  table = document.getElementById(divId);
  switching = true;
  // Set the sorting direction to ascending:
  dir = "asc";
  /* Make a loop that will continue until
  no switching has been done: */
  while (switching) {
    // Start by saying: no switching is done:
    switching = false;
    rows = table.rows;
    /* Loop through all table rows (except the
    first, which contains table headers): */
    for (i = 1; i < (rows.length - 1); i++) {
      // Start by saying there should be no switching:
      shouldSwitch = false;
      /* Get the two elements you want to compare,
      one from current row and one from the next: */
      x = rows[i].getElementsByTagName("td")[n];
      y = rows[i + 1].getElementsByTagName("td")[n];
      /* Check if the two rows should switch place,
      based on the direction, asc or desc: */
      if (dir == "asc") {
        if (x.innerHTML.toLowerCase() > y.innerHTML.toLowerCase()) {
          // If so, mark as a switch and break the loop:
          shouldSwitch = true;
          break;
        }
      } else if (dir == "desc") {
        if (x.innerHTML.toLowerCase() < y.innerHTML.toLowerCase()) {
          // If so, mark as a switch and break the loop:
          shouldSwitch = true;
          break;
        }
      }
    }
    if (shouldSwitch) {
      /* If a switch has been marked, make the switch
      and mark that a switch has been done: */
      rows[i].parentNode.insertBefore(rows[i + 1], rows[i]);
      switching = true;
      // Each time a switch is done, increase this count by 1:
      switchcount ++;
    } else {
      /* If no switching has been done AND the direction is "asc",
      set the direction to "desc" and run the while loop again. */
      if (switchcount == 0 && dir == "asc") {
        dir = "desc";
        switching = true;
      }
    }
  }
}
bbelderbos commented 8 months ago

And voila, Ryan added the plugin part - thanks! :)

jwjacobson commented 8 months ago

datatables looks great! I think it was actually used by that website I put in the mindmap as a reference: https://xteddy.org/lsm/

bbelderbos commented 8 months ago

Yeah when you write JS like above maybe it's time to pause and reflect and use a nice plugin lol.