search

jwjimmy / counsel

A web tracker for low-volume web properties.
0 stars 0 forks source link

Devices should belong to users #8

Closed jwjimmy closed 7 years ago

jwjimmy commented 7 years ago

How to extend the Device model: https://django-fcm.readthedocs.io/en/latest/extending_device.html

This is an example of someone extending the Device model to have User as a foreign key: https://github.com/Chitrank-Dixit/django-fcm/issues/29

jwjimmy commented 7 years ago

My current issue is that the built in serializers in django-fcm do not support my custom Device model.

jwjimmy commented 7 years ago

I fixed the serializer issue in my fork of django-fcm (https://github.com/jwjimmy/django-fcm), and submitted PRs for my changes. Everything is fine and dandy when I run my app locally. On Heroku it recognizes the CounselDevice extension of Device but does not register my updates to django-fcm for some reason.

I will have to investigate later.

jwjimmy commented 7 years ago

Yes!!! Forcing editable mode caused the changes to register on the deployed app. https://github.com/jwjimmy/counsel/commit/27e11065f3497a2a0d676545b7b3372dcdbd0222

I have no clue why this is the case... supposedly Heroku is fetching all of the code from the git repo I specify in requirements.txt either way.

But prepending -e causes it to work.