search

jwkerr / Tabby

Tabby is a highly customisable Fabric mod for Minecraft that adds extra utility to the tab list
https://modrinth.com/mod/tabby
MIT License
8 stars 4 forks source link

Add translation strings for config tooltips #9

Closed FurnyGo closed 1 year ago

FurnyGo commented 1 year ago

Make config tooltips translatable

jwkerr commented 1 year ago

if you can make a pull request for another language i can add it

FurnyGo commented 1 year ago

if you can make a pull request for another language i can add it

en_us.json doesn't have localization keys for tooltips

GalaxyGaming2000 commented 1 year ago

if you can make a pull request for another language i can add it

en_us.json doesn't have localization keys for tooltips

What do you mean?

FurnyGo commented 1 year ago

if you can make a pull request for another language i can add it

en_us.json doesn't have localization keys for tooltips

What do you mean?

look this https://github.com/Fruitloopins/Tabby/blob/master/src/main/resources/assets/tabby/lang/en_us.json and this https://github.com/Fruitloopins/Tabby/blob/master/src/main/java/com/fwloopins/tabby/config/TabbyConfig.java no translate keys for @Comment sections (looks like tooltips in minecraft)

jwkerr commented 1 year ago

i'll have a look at adding it tomorrow

jwkerr commented 1 year ago

@FurnyGo i've added config tooltip translation strings