search

jwkvam / jupyterlab-vim

:neckbeard: Vim notebook cell bindings for JupyterLab
MIT License
975 stars 73 forks source link

Installation not working on node 10.4, works on 9.11 #55

Open kzawisto opened 6 years ago

kzawisto commented 6 years ago

Installation hangs forever on following output with node 10.4

> node /data/scratch/krystian/conda3/lib/python3.6/site-packages/jupyterlab/staging/yarn.js install
yarn install v1.5.1
info No lockfile found.
[1/4] Resolving packages...

Downgrading node to 9.11 fixes the issue.

Steps to reproduce: Run usual installation. I am using latest anaconda /w python 3.6 distribution here 

conda install -c conda-forge nodejs
jupyter labextension install jupyterlab_vim
# does not work

When nodejs is downgraded the installation works.

conda install -c conda-forge nodejs=9.11.1
jupyter labextension install jupyterlab_vim
#works

Thanks.

ah- commented 6 years ago

Hi, could you maybe try this again with JupyterLab 0.34? The jupyterlab-vim release for that should be up soon, and I've read that 0.34 added support for node 10.

And after testing with node v10.9.0 it all seems to work for me.

jwkvam commented 6 years ago

FWIW I ran into this issue when upgrading to jlab 0.34 https://github.com/jupyterlab/jupyterlab/issues/5191

I was able to work around it by uninstalling jupyterlab-vim. I've also tested it works with node v10.9.0