Jupyter lab 0.34: ESC goes to Jupyterlab command mode instead of vim command mode

jwkvam / jupyterlab-vim

:neckbeard: Vim notebook cell bindings for JupyterLab

MIT License

975 stars 73 forks source link

Jupyter lab 0.34: ESC goes to Jupyterlab command mode instead of vim command mode #58

Closed lrvdijk closed 6 years ago

lrvdijk commented 6 years ago

Hi,

I just upgraded Jupyter Lab itself to 0.34 and upgraded the plugin to version 0.9.0 (from github). I've noticed an issue though: when you're in vim insert mode (in a cell), pressing ESC brings you to Jupyter command mode instead of vim command mode.

Kind regards, Lucas

ah- commented 6 years ago

Wow, you're fast. I'll have a closer look in a bit.

ah- commented 6 years ago

Do you have an example? I just gave it a go and it seems to work as before, but I'm probably missing something.

This is how it looks for me: https://i.imgur.com/IjWHS7g.mp4

lrvdijk commented 6 years ago

Hmm, maybe my browser was using cached javascript or something. Did another rebuild of Jupyter, restarted everything and now everything works as it should be indeed. Excuse me!

Thanks a lot for this plugin!

ah- commented 6 years ago

Ha, great, thanks for testing! :)