search

jwkvam / jupyterlab-vim

:neckbeard: Vim notebook cell bindings for JupyterLab
MIT License
973 stars 73 forks source link

React development mode is on #79

Closed sztal closed 5 years ago

sztal commented 5 years ago

Hi,

it seems that after installing the vim extensions the jupyter lab application is recognized as being run in the React development mode by the react devtools. I guess this should not be the case (due to both security and performance reasons).

jwkvam commented 5 years ago

Thanks for pointing this out, I agree, I don't want this plugin putting it in dev mode. I wonder why that would be...

sztal commented 5 years ago

I guess this may be helpful: https://stackoverflow.com/questions/22118915/how-to-turn-on-off-reactjs-development-mode

jwkvam commented 5 years ago

Hmm, I uninstalled it and I still see the red icon from the chrome extension for jupyterlab. So maybe it's just a jupyterlab thing? How are you checking? image

sztal commented 5 years ago

I checked with Firefox React devtools extension. As far as I remember, before installing the VIM extension Jupyter lab was properly marked as production version.

ian-r-rose commented 5 years ago

This is a problem with JupyterLab. The flag for a production mode build was broken. It has been fixed now (https://github.com/jupyterlab/jupyterlab/pull/5723), but is not in any published releases. When that happens, you should be able to specify a prod build with jupyter lab build --dev-build=false

sztal commented 5 years ago

Ok, thanks for info. It seems we may close this issue then.