Please finish the following when submitting a pull request:
[x] Add a line to History.md briefly documenting the change.
If this is a release, additionally do the following:
[x] Bump the package version in package.json
[x] Update the dependencies in package.json
[x] Run jlpm install to update yarn.lock
This supports jupyterlab 1.0.2 (and presumably 1.0.0-1.0.2 but I've not tested). It seems 1.0.1+ broke this addon by lazy loading codemirror/keymaps/vim.js, which this addon relies on being loaded. I've now added an import statement to make sure this available thus resolving the issue. Perhaps we could lazy load it as well? But might not be worth the dev effort since if you've installed this plugin you definitely want vim mode!
jwkvam
commented
5 years ago
Please finish the following when submitting a pull request:
History.mdbriefly documenting the change.If this is a release, additionally do the following:
package.jsonpackage.jsonjlpm installto updateyarn.lockThis supports jupyterlab 1.0.2 (and presumably 1.0.0-1.0.2 but I've not tested). It seems 1.0.1+ broke this addon by lazy loading
codemirror/keymaps/vim.js, which this addon relies on being loaded. I've now added an import statement to make sure this available thus resolving the issue. Perhaps we could lazy load it as well? But might not be worth the dev effort since if you've installed this plugin you definitely want vim mode!I've bumped the deps and updated the typescript config to be compliant with the changes listed for 1.0.0 at https://jupyterlab.readthedocs.io/en/stable/getting_started/changelog.html
Let me know if anything else needs work. it'd be great to get this merged to master so we can have a working vim addon installed from npm again!
Thanks jwkvam for all your awesome work on this plugin, I'd still be on jupyter notebook without it :D