Closed jwmcglynn closed 5 months ago
Attention: Patch coverage is 82.66667%
with 26 lines
in your changes missing coverage. Please review.
Project coverage is 88.87%. Comparing base (
af5964f
) to head (4e3e2a8
).
Files | Patch % | Lines |
---|---|---|
donner/css/parser/ColorParser.cc | 67.44% | 10 Missing and 4 partials :warning: |
donner/css/Color.cc | 79.59% | 9 Missing and 1 partial :warning: |
donner/css/Color.h | 71.42% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Implements the hwb()
function parsing in ColorParser
and adds corresponding unit tests.
hwb()
function within ColorParser::parseColor()
, handling conversion from HWB to RGBA color space, including optional alpha value handling.ColorParser_tests.cc
for various HWB color values and their conversion to RGBA, verifying correct parsing and conversion, including tests with optional alpha channel.For more details, open the Copilot Workspace session.
Related to #6
Implements support for HSLA color representation and updates the
Color
class to handle deferred conversion from HSLA to RGBA. Additionally, updates and adds unit tests to validate these changes.Color Class Enhancements
HSLA
struct to represent HSLA color values, including hue, saturation, lightness, and alpha components.hasHSLA()
andhsla()
methods to check for HSLA color type and retrieve HSLA values, respectively.resolve()
method to include logic for converting HSLA to RGBA, though the actual conversion logic is marked as a placeholder.Unit Test Updates
Color_tests.cc
to verify deferred conversion functionality for HSLA colors, ensuring that HSLA colors are correctly identified and their components are accessible.For more details, open the Copilot Workspace session.