jwmcglynn / donner

Donner SVG, a modern C++20 SVG rendering library supporting the latest SVG2 and CSS3 standards
https://jwmcglynn.github.io/donner/
ISC License
13 stars 1 forks source link

Update PropertyRegistry to support clip-rule property #171

Closed jwmcglynn closed 4 months ago

jwmcglynn commented 4 months ago

This pull request introduces support for the clip-rule property in the PropertyRegistry class, enhancing the SVG properties handling capabilities of the project.


For more details, open the Copilot Workspace session.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.21519% with 18 lines in your changes missing coverage. Please review.

Project coverage is 89.13%. Comparing base (3c12464) to head (49a4bc3). Report is 1 commits behind head on main.

Files Patch % Lines
donner/svg/properties/PropertyRegistry.cc 59.25% 7 Missing and 4 partials :warning:
donner/svg/core/ClipRule.h 0.00% 5 Missing :warning:
donner/svg/components/layout/LayoutSystem.cc 97.05% 0 Missing and 1 partial :warning:
donner/svg/renderer/RendererSkia.cc 90.90% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #171 +/- ## ========================================== - Coverage 89.38% 89.13% -0.25% ========================================== Files 254 255 +1 Lines 20276 20312 +36 Branches 2109 2119 +10 ========================================== - Hits 18123 18105 -18 - Misses 1561 1580 +19 - Partials 592 627 +35 ``` | [Flag](https://app.codecov.io/gh/jwmcglynn/donner/pull/171/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeff+McGlynn) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/jwmcglynn/donner/pull/171/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeff+McGlynn) | `89.13% <77.21%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Jeff+McGlynn#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.