CSS Selector Support - Githubissues

jwmcglynn / donner

Donner SVG, a modern C++20 SVG rendering library supporting the latest SVG2 and CSS3 standards

https://jwmcglynn.github.io/donner/

ISC License

13 stars 1 forks source link

CSS Selector Support #3

Closed jwmcglynn closed 3 months ago

jwmcglynn commented 1 year ago

[x] #2
[x] Support Pseudo-element Selectors
[x] Support Pseudo-class Selectors
[x] Match against namespaces in TypeSelector
[x] Parser support for An+B micro-syntax
[x] For :nth-last-child the [of S]? syntax should accept an forgiving selector list

jwmcglynn commented 1 year ago

Here's a good list of pseudo class selectors to initially support, from librsvg: https://gnome.pages.gitlab.gnome.org/librsvg/devel-docs/features.html#pseudo-classes

jwmcglynn commented 6 months ago

Pseudo-class selectors from https://www.w3.org/TR/selectors-4/

[x] :root
[x] :empty
[x] :first-child
[x] :last-child
[x] :only-child
[x] :nth-child()
[x] :nth-last-child()
[x] :is()
[x] :not()
[x] :where()
[x] :has()
[x] :nth-of-type()
[x] :nth-last-of-type()
[x] :first-of-type
[x] :last-of-type
[x] :only-of-type
[x] :defined
[x] :scope

jwmcglynn commented 6 months ago

Initial pseudo-class selectors are in 4a51f7d9f79f7b33f8cb2f68ab35981a0844e32e

jwmcglynn commented 6 months ago

a2fac7fcc727398dc7f8b07d8dc6890c1f6ff08c adds support for these ones

:first-of-type
:last-of-type
:only-of-type
:nth-of-type(...)
:nth-last-of-type(...)

jwmcglynn commented 6 months ago

Currently :nth-of-type(... [of S]?) only accepts a TypeSelector, it needs to be updated to parse a forgiving-selector-list. Added to the description.

Per the CSS spec:

The :nth-child(An+B [of S]? ) pseudo-class notation represents elements that are among An+Bth elements from the list composed of their inclusive siblings that match the selector list S, which is a parsed as a forgiving selector list. If S is omitted, it defaults to |.

https://www.w3.org/TR/selectors-4/#nth-child-pseudo

jwmcglynn commented 4 months ago

Initial support for :is(), :where(), :not() added in https://github.com/jwmcglynn/donner/commit/56b9b64982c661723c9dd6655614a53f65e927d9

jwmcglynn commented 4 months ago

:nth-of-type(... of S) now accepts a <forgiving-selector-list>, as defined by the latest Selectors 4 spec: https://www.w3.org/TR/2022/WD-selectors-4-20221111/#forgiving-selector
Pseudo-elements are not relevant for SVG, only HTML.
https://github.com/jwmcglynn/donner/commit/f93c4bcbe3ffd94cd5190b3316f70984c324bf38 adds support for calculating the specificity of pseudo-classes.

Remaining work before closing out this task are :has() and :defined, and maybe :scope.

For :has(), support needs to be added for parsing a <forgiving-relative-selector-list>.

There's a long tail of other pseudo-classes, but most are only relevant once other features such as interactivity, animation, or localization are added.

jwmcglynn commented 3 months ago

:scope support added in 99ba003a669b9e62746b31235529cfd58abdf583

jwmcglynn commented 3 months ago

https://github.com/jwmcglynn/donner/commit/5a8bace904bf19e5c36043dbcff0ea9630c3abc7 adds support for :has()

jwmcglynn commented 3 months ago

https://github.com/jwmcglynn/donner/commit/16db844773dc831a876278756283c67b3a9c54b1 implements :defined