jwmesa412 / i7z

Automatically exported from code.google.com/p/i7z
GNU General Public License v2.0
0 stars 0 forks source link

Enhancement of Makefile #44

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Please find attached a patch against rev 81 for the Makefile. This enhances 
following points:

* Allows parallel make call via -jN flags. Here a correct dependency resolution 
was needed.
* Separates compilation of C code and linking. This allows linker to be more 
effective, especially with flags like --as-needed
* Defines CC only if not defined through env. This is needed for 
crosscompilation and similar.
* Adds optimization and debug to CLFAGS only if CFLAGS aren't defined in env. 
This allows more customization and last issue was fixed in bug 43.
* Sum up CFLAGS via += instead of defining them through several variables.
* Use LDFLAGS and LIBS for the correct purposes. LDFLAGS specify linker 
directives, LIBS specify libs to link to.
* Use optimal order for linking: LINKER LDFLAGS OBJ LIBS. Although other orders 
also allow linking the best result can be obtained by this order 
(http://blog.flameeyes.eu/tag/asneeded 
http://www.gentoo.org/proj/en/qa/asneeded.xml)

Please include or discuss any criticism.

Original issue reported on code.google.com by ju.lec...@googlemail.com on 31 Dec 2011 at 12:36

Attachments:

GoogleCodeExporter commented 8 years ago
thanks a lot. sorry for my late followup.

the patch works great

i ran into one issue though, i was using icc and i think it doesnot support the 
-nofschedule-insns and insns2 flags, so that might come up as an issue later.

btw, i am not sure how gentoo gets the package, do tell if you need me to bump 
up a version with this patch. thanks.

Original comment by abhirana on 8 Jan 2012 at 7:52

GoogleCodeExporter commented 8 years ago
I am the maintainer of i7z on Gentoo. I am trying to follow upstream as close 
as possible. Currently I take the latest version and apply this patch. So you 
could either bump for the inclusion of the patch or wait for the next regular 
bump.

the problems with CFLAGS_FOR_AVOIDING_SEG_FAULT could probably shipped around 
by only defining it with gcc, which should be a simple one.

Original comment by ju.lec...@googlemail.com on 8 Jan 2012 at 8:04

GoogleCodeExporter commented 8 years ago
thanks. i think i will wait till the next major bump for including the Makefile.

thanks. have a good day.

Original comment by abhirana on 9 Jan 2012 at 6:43

GoogleCodeExporter commented 8 years ago

Original comment by abhirana on 31 Mar 2012 at 8:34