search

jwodder / javaproperties

Python library for reading & writing Java .properties files
MIT License
30 stars 10 forks source link

Add ensure_ascii to PropertiesFile dump #13

Closed bhack closed 3 years ago

bhack commented 3 years ago

Fix https://github.com/jwodder/javaproperties/issues/12

codecov[bot] commented 3 years ago

Codecov Report

Merging #13 (92b5d5e) into master (9dab5b5) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files           7        7           
  Lines         555      555           
  Branches      119      119           
=======================================
  Hits          553      553           
  Misses          1        1           
  Partials        1        1
Impacted Files Coverage Δ
src/javaproperties/propfile.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dab5b5...92b5d5e. Read the comment docs.

jwodder commented 3 years ago

This PR only adds ensure_ascii to PropertiesFile.dumps(), not PropertiesFile.dump(), and line 243 should be ensure_ascii=ensure_ascii, not ensure_ascii=None. I've gone ahead and made the full, correct changes myself.

bhack commented 3 years ago

PropertiesFile.dumps(), not PropertiesFile.dump() Yes but the inverse. Sorry I was quite busy to push the other commits it was WIP. Thanks