Closed jwodder closed 10 months ago
Decision: When processing a user-supplied label name, labelmaker
will perform the same normalizations that GitHub does (i.e., stripping leading & trailing ASCII whitespace and converting LFs to SP), but it won't bother enforcing GitHub's rules about characters that cause label creation to error.
GitHub rejects label names that are entirely composed of emoji characters (not to be confused with label names entirely composed of emoji shortcuts, which are accepted).
labelmaker
should reject these as well.It's likely that GitHub enforces further checks, such as prohibiting control characters. Validate for these as well.
Observations so far:
/
?
?
is created, GitHub will not percent-escape the character when constructing the label's URL for use in API responses, and trying to operate on the this URL gives the wrong results.%
?
.