search

jwoehr / qisjob

Qiskit Job Control
Other
32 stars 4 forks source link

add job_monitor line_discipline control #12

Closed omarcostahamido closed 1 year ago

omarcostahamido commented 3 years ago

following our slack discussion (thanks 😄 ) and the work done here https://github.com/Qiskit/qiskit-terra/pull/5691

omarcostahamido commented 3 years ago

from our slack discussion, here are the next steps (written by Jack):

- Add kwargs to QisJob ctor
- Add args to the argparse section(s)
- Add fetching the argparse args and feeding them to the QisJob ctor
- Add logic in the methods that invoke the job monitor.
I don't think we should assume the defaults and make them defaults of the QisJob ctor.
Instead, we should write logic that omits the kwarg if the ctor leaves it set to None and applies the kwarg if the user gave it some value.
Since once we have this change in, there's always the chance it will "inspire" the Qiskit Team to change the default.
jwoehr commented 3 years ago

Did your pull request to Terra get noticed?