search

jwoehr / qisjob

Qiskit Job Control
Other
32 stars 4 forks source link

don't quit python please! 🛑 #17

Closed omarcostahamido closed 3 years ago

omarcostahamido commented 3 years ago

beside the using it in the terminal, I am now exploring using qisjob in a python script. (long story short, I'm trying to find ways to cut on the time spend just loading python, see more on #16 ) It seems that once the do_it() method gets called on any QisJob object, it will quit the python. For the laymen (such as me self), it's all the sys.exit(some number?) on the qis_job.pyx that need not to be run.

OCH

omarcostahamido commented 3 years ago

For the record: I think qisjob works as intended in the terminal, so please don't break it. Now, if it is possible to know when we are in the python script world, and change the behavior there, then yes, that will make sense to change it, and will be helpful.

jwoehr commented 3 years ago

I opened an issue_17 branch and checked in some code that will work better. It will still exit on certain errors, like a job failure. Totally removing sys.exit() will take more control flow work and I can't do that tonite.

jwoehr commented 3 years ago

This is a good change. It really should only exit when running as a script. The object itself should never call sys.exit(). Thanks for bringing this to my attention. QisJob is two years old soon and has gone through much evolution :)

jwoehr commented 3 years ago

Been looking at how to straighten this all out. I have to document better each method in the QisJob class. Then I have to redo some code that's been sitting there for two years. So the "real" fix is not a one-day thing. It's going to be a fairly major change in QisJob.

omarcostahamido commented 3 years ago

No problem. I don't think it is that urgent, I can live with the 1300ms delay right now. I will be able to focus on improving this more probably after the PhD 0:-)

On Mon, Feb 15, 2021 at 6:09 PM Jack J. Woehr notifications@github.com wrote:

Been looking at how to straighten this all out. I have to document better each method in the QisJob class. Then I have to redo some code that's been sitting there for two years. So the "real" fix is not a one-day thing. It's going to be a fairly major change in QisJob.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jwoehr/qis_job/issues/17#issuecomment-779536236, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEL4NAD7TLRZEBCGQNZWNKDS7HHVBANCNFSM4XTZNLQQ .

jwoehr commented 3 years ago

Closed by b1cea140cd318a65808fcdd786c63096c284d226

omarcostahamido commented 3 years ago

thank you. it is a-working now!