search

jwohlfert23 / react-native-tag-input

A simple React Native component that creates an input for tags, emails, etc.
MIT License
232 stars 104 forks source link

Scrollview when having a lot of tags #13

Closed sibelius closed 7 years ago

sibelius commented 7 years ago

If I have many tags selected, this component grows indefinitely

Would be good to provide a ScrollView to make it possible to select many items

the scroll should be customizable (horizontal or vertically), number of lines should also be customizable

In my screenshot above, I think 2/3 lines would be a good number.

image

I made 2 pull requests to improve the code and code style

this one https://github.com/jwohlfert23/react-native-tag-input/pull/11 add onChangeText prop support, as I would like to load some suggestions based on user typing

the second one: https://github.com/jwohlfert23/react-native-tag-input/pull/12 add eslint react and react-native specific rules to improve code style

I will try to work on the ScrollView implementation and I'll send a pull request soon

sibelius commented 7 years ago

fixed with https://github.com/jwohlfert23/react-native-tag-input/pull/15