jwohlfert23 / react-native-tag-input

A simple React Native component that creates an input for tags, emails, etc.
MIT License
232 stars 104 forks source link

wrapperHeight refactor #37

Closed Ashoat closed 6 years ago

Ashoat commented 6 years ago

Currently, wrapperHeight is determined in the following way:

My proposal:

Relatedly, this PR changes the logic for when scrollToBottom gets triggered. In this PR it gets called whenever this.contentHeight increases. In the current version, it gets triggered whenever onLayoutLastTag gets called and the max this.props.numberOfLines has already been reached. I found the current behavior buggy, and it doesn't always get triggered when you would expect it to.