search

jwohlfert23 / react-native-tag-input

A simple React Native component that creates an input for tags, emails, etc.
MIT License
231 stars 104 forks source link

Support configuration for inputDefaultWidth #46

Closed JaxGit closed 6 years ago

JaxGit commented 6 years ago

Personally I have a placeholder longer than 90 so I think this is useful :)

JaxGit commented 6 years ago

... Please hold this PR for a moment, although it seems to work independently, I am currently having problems trying to merge all PRs in my temporary branch

JaxGit commented 6 years ago

False alarm. I figured out that one of the inputWidth function invocation has been moved from componentWillUpdate to componentWillReceiveProps in text lifting PR #43 . As a result when merging #43 and this branch, it needs to manually apply the new function signature to invocation in componentWillReceiveProps like I did in my temporary merging branch

JaxGit commented 6 years ago

You are right. Rebased, ran Flow then fixed the type errors and format the function signature. Thank you!

Ashoat commented 6 years ago

Something went wrong with your rebase. Can you try again? All of my commits should be below all of yours for it to work correctly.

JaxGit commented 6 years ago

Thanks for your patience, I was not so familiar with it and merged instead of force pushed after rebase. Should be ok now, also squashed a bit.

Ashoat commented 6 years ago

Awesome, this is perfect! Sorry it took so long, but glad you took the time to revise it.

I'll wait until we get #44 in before releasing a new package version.