jwons / raas

MIT License
2 stars 0 forks source link

Should preprocessing copy+paste sourced scripts into script that calls source()? #31

Closed jwons closed 3 years ago

jwons commented 3 years ago

This concept was discovered in issue #10.

In the preprocess_source script, do we really need a recursive call to preprocess_when we find a source call? The script will get preprocessed anyway (assuming all scripts get preprocessed). However, a comment in this section makes an interesting point, it says that the code copies and pastes the source script into the current script. It doesn't do this.... but, it possibly should. Since that is the behaviour of a source() call. In any case, the code here likely should change, as part of our cleaning. At the moment this recursive call is useless.

jwons commented 3 years ago

This now being done, pushed to freeze-fixes