search

jwood / tenacity

A database client independent way of managing relationships between models backed by different databases.
MIT License
118 stars 17 forks source link

Added Conditions to activerecord #30

Open danielgranat opened 12 years ago

danielgranat commented 12 years ago

I followed your advice on how to add it, and its done. You can see a test that adds 4 Seets to the Car. 2 are front seets, 2 back seets, 1 seet from the front is the drivers seet. This one is only added in code to the front seet, but pulled form the DB as driver (using conditions)

LMK what you think, and if there is anything else that needs to be added/removed

Daniel

jwood commented 12 years ago

Hi Daniel,

Looks good. This functionality will also need to be added to the DataMapper and Sequel adapters as well. Any interest in looking into that? I'm busy right now with some other projects, so it may take me a while to make that change.

John

danielgranat commented 12 years ago

That is odd... i see the change on my FS but git shows nothing that's changed.. I will update you when this is fixed

On Fri, Aug 19, 2011 at 2:55 PM, jwood reply@reply.github.com wrote:

Hi Daniel,

Looks good.  This functionality will also need to be added to the DataMapper and Sequel adapters as well.  Any interest in looking into that?  I'm busy right now with some other projects, so it may take me a while to make that change.

John

Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/30#issuecomment-1850295

danielgranat commented 12 years ago

My mistake, i was looking at the master branch. Your intention is that both DataMapper and Sequel should use the condition and not just change the function interface?

I might have some time to do that..

Daniel

On Fri, Aug 19, 2011 at 4:59 PM, Daniel Granatshtain daniel.granat@gmail.com wrote:

That is odd... i see the change on my FS but git shows nothing that's changed.. I will update you when this is fixed

On Fri, Aug 19, 2011 at 2:55 PM, jwood reply@reply.github.com wrote:

Hi Daniel,

Looks good.  This functionality will also need to be added to the DataMapper and Sequel adapters as well.  Any interest in looking into that?  I'm busy right now with some other projects, so it may take me a while to make that change.

John

Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/30#issuecomment-1850295

jwood commented 12 years ago

Correct. Ideally this setting would be used by any of the SQL based libraries.

danielgranat commented 12 years ago

Make sense. i wasn't aware of any other SQL based extensions. Should it be any different then the activerecord one? Just add the conditions in the same way?

On Fri, Aug 19, 2011 at 5:10 PM, jwood reply@reply.github.com wrote:

Correct.  Ideally this setting would be used by any of the SQL based libraries.

Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/30#issuecomment-1851247

jwood commented 12 years ago

The implementation will need to be slightly different for the other library extensions. The ActiveRecord implementation uses sanitize_sql to build the conditions, but that is implemented in ActiveRecord::Base. We'll need to find a way of doing this specific to each library, since ActiveRecord may not be loaded if somebody is using DataMapper and Mongoid, for example.

jwood commented 12 years ago

Oh...one other thing Daniel. I noticed a spelling error in the code. It's "seat" instead of "seet". If you're in the code adding support for the other libraries, would you mind correcting this?

danielgranat commented 12 years ago

oops... will do

On Fri, Aug 19, 2011 at 6:59 PM, jwood reply@reply.github.com wrote:

Oh...one other thing Daniel.  I noticed a spelling error in the code.  It's "seat" instead of "seet".  If you're in the code adding support for the other libraries, would you mind correcting this?

Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/30#issuecomment-1852339

danielgranat commented 12 years ago

Hi john, I fixed the Stear thing.

As for the other class, i don't think i will have time to handle that in the near future.

Daniel.

On Sat, Aug 20, 2011 at 10:34 AM, Daniel Granatshtain daniel.granat@gmail.com wrote:

oops... will do

On Fri, Aug 19, 2011 at 6:59 PM, jwood reply@reply.github.com wrote:

Oh...one other thing Daniel.  I noticed a spelling error in the code.  It's "seat" instead of "seet".  If you're in the code adding support for the other libraries, would you mind correcting this?

Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/30#issuecomment-1852339

jwood commented 12 years ago

Ok, thanks Daniel. I'll merge your commit into a topic branch, and continue to work on adding support for the :conditions to the other SQL based libraries when I'm free.

danielgranat commented 12 years ago

Thanks John.

This is a project i was working on for a company Pixfizz. Having the project ended, i will keep them posted of any progress and when they can move back to working with your code base.

Daniel

On Mon, Aug 22, 2011 at 3:52 PM, jwood < reply@reply.github.com>wrote:

Ok, thanks Daniel. I'll merge your commit into a topic branch, and continue to work on adding support for the :conditions to the other SQL based libraries when I'm free.

Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/30#issuecomment-1869838