Closed raphaelcm closed 12 years ago
This looks great Raphael, thanks! I'll get this merged in soon.
No problem, thanks for making/maintaining Tenacity. My company is going with "polyglot persistence" in a big way and this has been a huge help.
Sent from my iPhone
On Apr 23, 2012, at 6:03 PM, John Woodreply@reply.github.com wrote:
This looks great Raphael, thanks! I'll get this merged in soon.
Reply to this email directly or view it on GitHub: https://github.com/jwood/tenacity/pull/37#issuecomment-5293069
Fixed in version 0.5.6
Makes a couple tweaks so that tests can run "out of the box" on vanilla systems.
Also fixes two bugs:
Bug 1
Given the following setup:
This scenario throws an error:
Here's the error:
It's caused because the save method in
associate_proxy.rb
doesn't accept any arguments, such as:validate => false
, which gets automatically sent by ActiveRecord.Bug 2
If an object is unchanged, save returns false. This causes problems in typical controller update methods:
If the user visits the edit form and clicks 'update' without making any changes, the controller will render the edit form again, instead of going to the
:index
action, as it should.