jwood / tenacity

A database client independent way of managing relationships between models backed by different databases.
MIT License
118 stars 17 forks source link

Tenacity 0.5.6 gemspec format errors on heroku #38

Closed bsedat closed 12 years ago

bsedat commented 12 years ago

I'm seeing the following types of errors when trying to upgrade the tenacity gem on a heroku (bamboo stack) app. 0.5.5 and previous versions seems to install just fine.

I'm thinking it's likely related to http://blog.rubygems.org/2011/08/31/shaving-the-yaml-yak.html. Heroku uses a pretty ancient version of bundler/rubygems.

(much more of the same, replacing all '=' in the gemspec with #<Syck::DefaultKey:0x000000091d6f60>)
2012-05-02T00:31:49+00:00 app[web.1]:     s.add_dependency(%q<adapter-mongo>, ["#<Syck::DefaultKey:0x000000091d6f60> 0.5.4"])
2012-05-02T00:31:49+00:00 app[web.1]:   end
2012-05-02T00:31:49+00:00 app[web.1]: end
2012-05-02T00:31:49+00:00 app[web.1]: WARNING:  Invalid .gemspec format in '/app/.bundle/gems/ruby/1.9.1/specifications/tenacity-0.5.6.gemspec'
2012-05-02T00:31:49+00:00 app[web.1]: Could not find tenacity-0.5.6 in any of the sources
jwood commented 12 years ago

I just pushed a new commit to master (adb2a3b6f98bff6cc3fcaab7494994999861b266) that uses ~> to specify the development dependencies instead of =. Would you mind changing your Gemfile to point to master on github to see if it fixes your issue?

gem 'tenacity', :git => 'git@github.com:jwood/tenacity.git'

If it does, I will cut a new version of the gem.

bsedat commented 12 years ago

I had to use 'https://github.com/jwood/tenacity.git' as the git target in order for heroku to be able to pull the source. But in the end your fix seems to work. Thanks for the quick fix and great job with the gem!

bsedat commented 12 years ago

I had to use 'https://github.com/jwood/tenacity.git' as the git target in order for heroku to be able to pull the source. But in the end your fix seems to work. Thanks for the quick fix and great job with the gem!

jwood commented 12 years ago

Glad that fixed it. I'll cut a new version of the gem now.

jwood commented 12 years ago

Fixed in version 0.5.7

bsedat commented 12 years ago

Confirmed that the new gem version works. Thank you very much again!

jwood commented 12 years ago

No problem. Thanks for the bug report!